From f2ad309aef1bcc5e31e2c737c19a3e67a77b81d5 Mon Sep 17 00:00:00 2001 From: Paul Abel <128620221+pdabelf5@users.noreply.github.com> Date: Thu, 26 Sep 2024 10:54:18 +0100 Subject: [PATCH] prevent final result from succeeding if any image builds fail (#6509) --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8e7a70f48c..5b3492dfe6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -648,7 +648,7 @@ jobs: tag-stable: name: Tag tested image as stable - needs: [checks, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap] + needs: [checks, build-docker, build-docker-plus, build-docker-nap, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap] permissions: contents: read # To checkout repository id-token: write # To sign into Google Container Registry @@ -664,7 +664,7 @@ jobs: if: ${{ !cancelled() }} runs-on: ubuntu-24.04 name: Final CI Results - needs: [tag-stable, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap] + needs: [tag-stable, build-docker, build-docker-plus, build-docker-nap, smoke-tests-oss, smoke-tests-plus, smoke-tests-nap] steps: - run: | tagResult="${{ needs.tag-stable.result }}"