From 9f1c285e91fb5b0c2e0051b7bc5a2d1a882c4dbe Mon Sep 17 00:00:00 2001 From: Dean Coakley Date: Tue, 17 Nov 2020 09:51:36 +0000 Subject: [PATCH] Fix ingressclass semver comparison in helm chart Bug first appeared in: https://github.com/nginxinc/kubernetes-ingress/commit/d893dd093ea3582be48c03ed79c92bbf5ddd73d3 Helm will fail to install the ingressclass resource when the patch value of the semver contains some non-numerical suffix. For example: * v1.18.8-rc.1 * v1.18.10-gke.601 --- deployments/helm-chart/templates/controller-ingress-class..yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployments/helm-chart/templates/controller-ingress-class..yaml b/deployments/helm-chart/templates/controller-ingress-class..yaml index 0b3cc21ba1..04df66a30f 100644 --- a/deployments/helm-chart/templates/controller-ingress-class..yaml +++ b/deployments/helm-chart/templates/controller-ingress-class..yaml @@ -1,4 +1,4 @@ -{{- if semverCompare ">=1.18.0" .Capabilities.KubeVersion.GitVersion }} +{{- if semverCompare ">=1.18.0-0" .Capabilities.KubeVersion.GitVersion }} apiVersion: networking.k8s.io/v1beta1 kind: IngressClass metadata: