Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Its not working with CS API 4.19.1.1 #130

Open
sefimlog opened this issue Nov 12, 2024 · 17 comments
Open

Its not working with CS API 4.19.1.1 #130

sefimlog opened this issue Nov 12, 2024 · 17 comments

Comments

@sefimlog
Copy link

The login to the API was changed on 4.19, and the module doesn't support it yet.
'errorcode': 401, 'errortext': 'unable to verify user credentials and/or request signature'

@brutasse
Copy link
Contributor

hi @sefimlog - we no longer have interest in maintaining this library and would be open to handing it over to other parties interested.

@resmo
Copy link
Member

resmo commented Nov 23, 2024

The best possible way to maintain this library is probably under the apache cloudstack project.

In case there are no interests from the apache cloudstack community, I would like to offer to take under @ngine-io, where I already maintain the ansible integration for cloudstack which depends on cs. ngine-io is not a company or "person", just a project name.

Of course I would appreciate others to help me maintain it and with further development.

@brutasse
Copy link
Contributor

Thanks for the offer, @resmo!

I tried to initiate the repository transfer to @ngine-io but Github doesn't let me -- I'd need to have repository creation permissions on the destination org.

Could I get this permission temporarily, for the duration of the transfer?

You should have received an invite for PyPI in the meantime.

@brutasse
Copy link
Contributor

Hello from cs's new home!

@resmo
Copy link
Member

resmo commented Nov 27, 2024

Thank you, @brutasse, for all the work you've put into this project and for the quick transition to @ngine-io

@CodeBleu
Copy link

@resmo Really appreciate you taking this on and for both you and @brutasse for moving so quickly to get this transitioned.

Now we just need to figure out how to fix the actual issue in this Issue. Really need to get this working so it can be used with newer Cloudstack versions 4.19.x 😄

@resmo
Copy link
Member

resmo commented Nov 28, 2024

@CodeBleu I need a little more details what you are experiencing:

  • Which exact version do you experience this? What was the last working version?
  • Is there a release note which points to the breaking change?
  • Have you already been in contact with the cloudstack community about it? e.g. via the mailinglist?

I am aware of security fixes in cloudstack which may be related:

I am currently building a test container for 4.19 to reproduce this issue.

@resmo
Copy link
Member

resmo commented Nov 28, 2024

I was able to build and briefly run a smoke test on a 4.19.1.3 simulator and was not able to reproduce an issue:

  • cloudstack 4.19.1.3 simulator
  • latest cs 3.2.0
  • admin api credentials in ~/.cloudstack.ini
[cloudstack]
endpoint = http://localhost:8888/client/api
key = ...
secret = ...
  • command: cs listTemplates templatefilter=all recursive=true fetch_list=true
[
  {
    "account": "system",
    "bits": 0,
    "checksum": "",
    "created": "2024-11-28T08:03:41+0000",
    "crossZones": true,
    "deployasis": false,
    "details": {},
    "directdownload": false,
    "displaytext": "SystemVM Template (simulator)",
    "domain": "ROOT",
    "domainid": "4ce5670f-ad5d-11ef-b9a3-0242ac110002",
    "downloaddetails": [
      {
        "datastore": "nfs://nfsstor:/export/home/sandbox/secondary",
        "datastoreId": "fd1ffa09-01f9-4865-b18b-10298de7dfb5",
        "datastoreRole": "Image",
        "downloadPercent": "100",
        "downloadState": "DOWNLOADED"
      },
      {
        "datastore": "PS0-basic",
        "datastoreId": "416b18ef-adae-39e2-a86b-ba518578772d",
        "datastoreRole": "Primary",
        "downloadPercent": "100",
        "downloadState": "DOWNLOADED"
      }
    ],
    ...

could you please verify your configs?

@CodeBleu
Copy link

CodeBleu commented Nov 30, 2024

@resmo

  • Which exact version do you experience this?
    4.19.1.1
    What was the last working version?
    4.18.x
  • Is there a release note which points to the breaking change?
    Not that I'm aware of.
  • Have you already been in contact with the cloudstack community about it? e.g. via the mailinglist?
    Only the Github issue where I asked them if they wanted to take over this CS repo.
    SDK question apache/cloudstack-go#92

@resmo resmo changed the title Its not working with CS API 4.19 Its not working with CS API 4.19.1.1 Nov 30, 2024
@rohityadavcloud
Copy link

Thanks @resmo for stepping up! And @brutasse for helping with the transition.

@rohityadavcloud
Copy link

@resmo if you're looking to setup CI/Github actions support, feel free to look at https://github.com/apache/cloudstack-terraform-provider/blob/main/.github/workflows/setup-cloudstack/action.yml which is basically running CloudStack+Simulator in a container & then calling APIs to validate some basic checks.

@CodeBleu
Copy link

@resmo FYI, incase you didn't follow this issue.
apache/cloudstack-go#92 (comment)

@resmo
Copy link
Member

resmo commented Nov 30, 2024

Thanks for the hint, but I think we are fine to work on and maintain it since we heavily depend on this library, but maybe it would be a good idea to add another person to the pypi project just "in case" I somehow managed to loose access.

@rohityadavcloud do you have a pypi account? https://pypi.org/user/Rohit.Yadav? would you be okay to be added to https://pypi.org/project/cs/ just as a "backup"?

@resmo
Copy link
Member

resmo commented Nov 30, 2024

So back to the issue, I was able to add an integration test for 4.19.1.1 which turned out green https://github.com/ngine-io/cs/actions/runs/12100100185/job/33738343600?pr=137

@CodeBleu
Copy link

CodeBleu commented Dec 1, 2024

Since @sefimlog was the creator of this issue, I'm wondering if you are still having issues and what version of Cloudstack and CS module you are using @sefimlog ?

@resmo I originally added you to this because of needing support for this module going forward and I had done a quick test myself with a 4.19 and 4.18 environment. I originally was getting the 401 error as well in the 4.19 environment, but I just now went back to test again since you said it workd and marked it ias 'invalid'. When I went to test again, it is actually working for me as well. There is a chance I tested on a version of 4.19.x and didn't pay close attention to what the 'x' was and it might have been updated since. But my current test was on 4.19.1.1 and it seemed to work.

@rohityadavcloud
Copy link

Hi @resmo happy to be added as a backup on pypi, my username is indeed https://pypi.org/user/Rohit.Yadav/

@resmo
Copy link
Member

resmo commented Dec 1, 2024

@CodeBleu I somehow missed, you were not the reporter...

@sefimlog could you provide more infos, about which cloudstack version you experiencing that?

I marked the issue as "invalid" as I was not able to reproduce with latest 4.19, which should be a upgrade target anyway in case you run a outdated (security issue related) 4.19 but haven't upgraded yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants