Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow to change dropdown positioning. #154

Merged
merged 1 commit into from
Dec 5, 2017
Merged

feat: Allow to change dropdown positioning. #154

merged 1 commit into from
Dec 5, 2017

Conversation

aitboudad
Copy link
Contributor

part of #143

anjmao
anjmao requested changes Dec 4, 2017
View reviewed changes
Copy link
Member

@anjmao anjmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good :) Would be nice if you can add new demo page to show this new feature, it can be called Dropdown positions or so :)
Also you can update from master, I fixed travis build script and now build should run as expected.

@aitboudad
Copy link
Contributor Author

done

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 90.355% when pulling 489af45 on aitboudad:dropdown-position into 3008f21 on ng-select:master.

@anjmao anjmao merged commit 1e4d521 into ng-select:master Dec 5, 2017
@aitboudad aitboudad deleted the dropdown-position branch December 5, 2017 10:26
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this pull request Oct 16, 2018
@aitboudad @anjmao
feat: Allow to change dropdown positioning. (ng-select#154)
a0f2c6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anjmao anjmao anjmao requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aitboudad @coveralls @anjmao