Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it a bug or supposed behaviour? #385

Closed
plandem opened this issue Apr 19, 2022 · 2 comments · Fixed by #354
Closed

is it a bug or supposed behaviour? #385

plandem opened this issue Apr 19, 2022 · 2 comments · Fixed by #354
Assignees
Labels
Milestone

Comments

@plandem
Copy link

plandem commented Apr 19, 2022

https://github.com/Hypercontext/linkifyjs/blob/3eb5b8aacc286e57e220cd6ce2d9c139d96e7322/packages/linkifyjs/src/core/fsm.js#L79-L81

nextState.jr.append(templateState.jr);
nextState.jr = templateState.jd; // <- should not it be `nextState.jd` here?
nextState.t = token || templateState.t;
@nfrasser
Copy link
Owner

Hi @plandem, great catch, this is a bug. It's fixed in the latest v4.0.0-beta.5 (install with npm install linkifyjs@beta)

@nfrasser nfrasser mentioned this issue Apr 23, 2022
@nfrasser nfrasser added the bug label Apr 23, 2022
@nfrasser nfrasser self-assigned this Apr 23, 2022
@plandem
Copy link
Author

plandem commented Apr 24, 2022

Is it possible to fix v3?

@nfrasser nfrasser added this to the 4.0 milestone Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants