Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains that start with schemes should be accepted #374

Closed
jryans opened this issue Jan 25, 2022 · 3 comments · Fixed by #354
Closed

Domains that start with schemes should be accepted #374

jryans opened this issue Jan 25, 2022 · 3 comments · Fixed by #354
Assignees
@nfrasser
Labels
bug pending-merge
Milestone
4.0

Comments

@jryans
Copy link

jryans commented Jan 25, 2022

I recently noticed that domains which start with schemes (e.g. http) are currently ignored and not linked.

For example, all of the following should linkify the full text, as they are valid domains:

  • http.org
  • http-help.org
  • http123.org
@jryans
Copy link
Author

jryans commented Jan 25, 2022

I have already resolved this in a fork of the 4.0 branch. I'm happy to contribute that over here if you'd like.

@jryans jryans mentioned this issue Jan 25, 2022
Closed
@nfrasser nfrasser added this to the 4.0 milestone Jan 30, 2022
@nfrasser nfrasser added the bug label Jan 30, 2022
@nfrasser nfrasser self-assigned this Jan 30, 2022
@nfrasser nfrasser mentioned this issue Jan 30, 2022
Merged
@nfrasser
Copy link
Owner

Hi @jryans thanks for reporting. This is now fixed in the latest beta release v4.0.0-beta.3

@jryans
Copy link
Author

jryans commented Jan 31, 2022

Thanks for the quick fix! I have verified that v4.0.0-beta.3 indeed resolves this issue. 😄

@jryans jryans mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfrasser nfrasser

Labels
bug pending-merge
Projects
None yet
Milestone
4.0
Development

Successfully merging a pull request may close this issue.

v4.0 nfrasser/linkifyjs
2 participants
@jryans @nfrasser