-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deepEqual with react-fast-compare #402
Conversation
@shad-k looks like there is a failure in the build step. We will need to resolve before merging into master. I will have sometime tomorrow to look deeper into it. In the meantime, is it possible for you to merge master into your PR? |
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
======================================
Coverage 97.6% 97.6%
======================================
Files 3 3
Lines 292 292
======================================
Hits 285 285
Misses 7 7
Continue to review full report at Codecov.
|
@tmbtech Done. |
More out of curiosity, but what is the release timeline for this? The last time you guys published was over a year ago. I'm just wondering if it's pointless to implement the work around if you guys are releasing soon. |
I would like to merge #395 in first. Then we can publish a beta version for feedback. Thoughts? |
We are running into this issue now on our project as well so the sooner a release can get out the better. |
Agree with others here we also have the same issue, I think releasing this first makes more sense. |
Is there any ETA on the release of this fix? |
There seems to be a lot of projects depending on this fix. Can this be prioritised please? |
Yup. Will address right after the holidays. |
Thanks @tmbtech! I think the cjs and esm builds are gonna be great, but if it we could get this patched first that would be ideal IMO. |
Fixes #373