Add defaultTitle as fallback when title is not defined #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please note that the build is currently failing due to estools/escope#99 and babel/babel-eslint#243. |
| @@ -24,7 +24,7 @@ describe("Helmet", () => { | |||
| describe("title", () => { | |||
| it("can update page title", () => { | |||
| ReactDOM.render( | |||
| <Helmet title={"Test Title"} />, | |||
| <Helmet title={"Test Title"} defaultTitle={"Fallback"} />, | |||
There was a problem hiding this comment.
Sorry, nitpick, but if you could please put these props on new lines, like your other test case below, that would be great. Otherwise, everything looks perfect.
|
Thx @jmurzy, I made one line note, but it looks like a good solution. |
jmurzy
force-pushed
the
jmurzy-defaultTitle
branch
from
e211f6b to
843a320
Compare
|
@cwelch5 Fixed. Thanks! 🍺 |
|
@jmurzy Merging master in should fix the failing build. |
|
@doctyper Done. Thanks. 🍺 |
jmurzy
force-pushed
the
jmurzy-defaultTitle
branch
from
be8fb1a to
372a027
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a defaultTitle option to be used as fallback when a title is not defined.
yields
and,
when composed as a child, yields
Fixes #109.
Let me know if this is something you'd consider merging, and I'll sign the CLA.
🍺