Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All badges have the same behaviour #38

Closed
HLWeil opened this issue Nov 15, 2024 · 4 comments
Closed

All badges have the same behaviour #38

HLWeil opened this issue Nov 15, 2024 · 4 comments

Comments

@HLWeil
Copy link
Member

HLWeil commented Nov 15, 2024

Not sure if this behaviour is intended or if this repo is the correct place.

image

I have an ARC where I added the invenio and the plant-growth packages. When they're both passing and I click on any of the badges, I'm redirected to the ARCigator page. If the plant-growth package is not passing, clicking on the badges leads you to the tests page.

IMO clicking on the plant-growth badge should redirect to the tests page anyways (to e.g. see the non-critical failing tests) and only clicking on the invenio badge should redirect to the ARCigator page.

@Brilator
Copy link
Member

Yes!!

@kMutagene
Copy link
Member

kMutagene commented Dec 4, 2024

looks to me like an error in the default behaviour set on link creation when a package passes. Is it the case that archigator is always linked, even on non-invenio packages @j-bauer ? if so, that has to be fixed, defaulting to the tests if no hook url is set in the package metadata, and to the hook url otherwise.

@kMutagene
Copy link
Member

kMutagene commented Dec 4, 2024

Regardless, this seems to me like a data hub CI issue, so not for this repo, transferring to DataHUB

@kMutagene kMutagene transferred this issue from nfdi4plants/arc-validate-package-registry Dec 4, 2024
@j-bauer
Copy link
Collaborator

j-bauer commented Dec 6, 2024

Yes, this seems to be a bug. Only the invenio badge should point to archigator. I will look into this.

Update: it is fixed. Only the invenio badge will point to archigator. The other will point to the test pages, currently, until the hook URL stuff is implemented and used on both ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants