Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change repo to nf-core/actions #22

Closed
edmundmiller opened this issue Aug 31, 2023 · 4 comments
Closed

Change repo to nf-core/actions #22

edmundmiller opened this issue Aug 31, 2023 · 4 comments
Milestone

Comments

@edmundmiller
Copy link
Collaborator

edmundmiller commented Aug 31, 2023

Personally, I would love to see all nf-core testing workflows updated to use one install per repo per version, and then all tests are run off of that. I'm really inspired by Julia's testing workflow template. Unfortunately, Nextflow doesn't have as nice of a testing framework as Julia, so that may be a pipe dream.

That's nice. Do you not think that would work with nf-test?

That also makes me think we could move to a repo and pull in the GitHub actions like this repo https://github.com/magit/actions so it would just be:

steps:
    steps:
      - name: Install Nextflow
        uses: nf-core/actions/setup-nextflow@main
      - name: Install nf-core
        uses: nf-core/actions/setup-nf-core@main
      - name: Run nf-test
        uses: nf-core/actions/nf-test@main

Originally posted by @emiller88 in #19 (comment)

@MatthiasZepper
Copy link
Member

What is the rationale to reinstall e.g. Nextflow frequently (caching aside) over running those actions requiring it in a Docker container that already has the required dependencies installed?

@MillironX
Copy link
Member

Basically, because (until recently anyway) Nextflow behaves differently when inside of a Docker container than when it's outside of the container. (See docs, code).

@MatthiasZepper
Copy link
Member

MatthiasZepper commented Oct 26, 2023

Basically, because (until recently anyway) Nextflow behaves differently when inside of a Docker container than when it's outside of the container. (See docs, code).

Okay, yes, that's reasonable - I wasn't aware that we are actually testing containerized tasks somewhere. Thanks for letting me know and the effort to provide me with precise links to docs and code! Fascinating to see how Nextflow handles the Docker execution in that case!

@edmundmiller
Copy link
Collaborator Author

I was debating setting this up for the new nf-test CI workflow that was being worked on. But I think these will sadly need to be separate actions. https://github.com/tj-actions Otherwise we'll have a new version every time any other actions have a release.

I think we back off this and just keep things simple with separate repos.

@edmundmiller edmundmiller closed this as not planned Won't fix, can't repro, duplicate, stale Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants