Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bcftools mpileup #1099

Closed
amnghn opened this issue Jun 12, 2023 · 1 comment
Closed

Fix bcftools mpileup #1099

amnghn opened this issue Jun 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@amnghn
Copy link

amnghn commented Jun 12, 2023

Description of feature

Some versions of samtools and bcftools are not compatible so the pileup file generated by samtools mpileup cannot be read by bcftools call. Also, it seems bcftools call accepts only a piped input from bcftools mpileup. So the pileup files generated by samtools mpileup cannot finally be used for variant calling! I know there might be some ways to figure it out without adding a new feature to the pipeline but I have two suggestions to make Sarek even better:

  1. Replace samtools mpileup with bcftools mpileup.
  2. Add bcftool call for actual variant calling and generate the final vcf file.
@amnghn amnghn added the enhancement New feature or request label Jun 12, 2023
@FriederikeHanssen
Copy link
Contributor

Hey as discussed bcftools is already included. actually so is call and the final vcf files should be outputted: https://github.com/nf-core/sarek/blob/6c0d335e17fb4406f527540631da7b26a5fe1464/modules/nf-core/bcftools/mpileup/main.nf#LL36C5-L36C5

@FriederikeHanssen FriederikeHanssen changed the title Using bcftools mpileup (instead of samtools mpileup) for generating the pileup files Fix bcftools mpileup Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants