Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GATK4_CREATESEQUENCEDICTIONARY memory misspecification #1085

Closed
mjakobs opened this issue Jun 8, 2023 · 5 comments
Closed

GATK4_CREATESEQUENCEDICTIONARY memory misspecification #1085

mjakobs opened this issue Jun 8, 2023 · 5 comments

Comments

@mjakobs
Copy link

mjakobs commented Jun 8, 2023

Hi team, thanks for releasing sarek version 3.2.1!

While running the test profile (nextflow run nf-core/sarek -r 3.2.1 -profile test,singularity --outdir results -c my.config) I found that GATK4_CREATESEQUENCEDICTIONARY fails with Error: A JNI error has occurred, please check your installation and try again. It appears the module accidentally specifies 6MB memory rather than 6GB for this task.
Relevant code:
https://github.com/nf-core/sarek/blob/6c0d335e17fb4406f527540631da7b26a5fe1464/modules/nf-core/gatk4/createsequencedictionary/main.nf#LL22C1-L30C72

Proposed downstream fix would be to change the module. In the meantime, adding the following to my config file has worked for me:

withName: 'GATK4_CREATESEQUENCEDICTIONARY' {
        memory       = { 6.GB * task.attempt }
    }
@asp8200
Copy link
Contributor

asp8200 commented Jun 8, 2023

I suspect that there is a similar problem in GATK4_COMPOSESTRTABLEFILE.

@maxulysse
Copy link
Member

It's due to nf-core/modules#3027,
There are actually more modules to fix, thanks a lot @mjakobs for spotting that

@maxulysse
Copy link
Member

@asp8200 that's exactly the one I noticed too, I'm looking through all, and making a PR rn

@maxulysse
Copy link
Member

Will be fixed on the modules side by nf-core/modules#3502

@maxulysse
Copy link
Member

and will be closed by #1087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants