Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port parabricks/indexgvcf to nf-test #6996

Merged
merged 22 commits into from
Dec 11, 2024
Merged

port parabricks/indexgvcf to nf-test #6996

merged 22 commits into from
Dec 11, 2024

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Nov 14, 2024

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab requested a review from a team as a code owner November 14, 2024 15:14
@famosab famosab requested a review from mirpedrol November 14, 2024 15:14
@famosab famosab added gpu module uses GPU nf-test labels Nov 18, 2024
@famosab
Copy link
Contributor Author

famosab commented Nov 18, 2024

@nf-core-bot Can you fix the linting please?

@mashehu
Copy link
Contributor

mashehu commented Dec 9, 2024

are the tests passing on a test instance/local gpu cluster?

@famosab
Copy link
Contributor Author

famosab commented Dec 9, 2024

yes (I only tested with docker)

@jfy133
Copy link
Member

jfy133 commented Dec 10, 2024

Note I'm not familiar with the GPU udptes but mostly looksl ike adding tags to go on the right runner so fine with me from that PoV 👍

@famosab
Copy link
Contributor Author

famosab commented Dec 10, 2024

Note: the .idx file did not produce stable snapshots so I am just checking for the filename at the moment but I am happy to extend with other ideas.

@famosab famosab enabled auto-merge December 11, 2024 13:18
@famosab famosab added this pull request to the merge queue Dec 11, 2024
Merged via the queue into nf-core:master with commit a62c798 Dec 11, 2024
14 checks passed
@famosab famosab deleted the indexg branch December 11, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants