-
Notifications
You must be signed in to change notification settings - Fork 732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bumped MultiQC version for dumpsoftwareversions #6224
base: master
Are you sure you want to change the base?
Conversation
I wonder if this could also be replaced with the ubuntu container... I wonder if that has a basic python installation? |
I tried to run the ubuntu container but python is not installed in it |
@maxulysse pointed out that we don't use this anymore, but instead with a function in the template. He wondered if we should deprecate it. |
So, do we want to deprecate this? |
I don't know if we have a deprecation procedure do we? |
Oh James, I thought you knew the guidelines 😉. |
OH nice! Then yes, lets deprecate :) |
Added a message. I don't know what happens to the tests at that point, but they seem to be fine for the other modules so maybe they just ignore the assert? |
PR checklist
This just updates
dumpsoftwareversions
to the latest version of theMultiQC container.versions.yml
file.nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
Running the test fails because the versions are updated in the container, I am not sure how you usually go about updating the test.