Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exists to Schema #342

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Add exists to Schema #342

merged 4 commits into from
Oct 17, 2023

Conversation

edmundmiller
Copy link
Collaborator

@edmundmiller edmundmiller commented Aug 28, 2023 •
edited
Loading

Tried to fix up the schema in #329, but it was really out of sync. Some stuff might have gotten broken.

Otherwise, we need to go through and add exists to the file checks.

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3d63bca

+| ✅ 156 tests passed       |+
#| ❔   3 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file
  • pipeline_todos - TODO string in WorkflowMethylseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-17 08:47:08

@github-actions
Copy link

nf-core lint overall result: Passed ✅

Posted for pipeline commit 907169c

+| ✅ 155 tests passed       |+
#| ❔   3 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-08-28 22:49:54

@edmundmiller edmundmiller mentioned this pull request Aug 28, 2023
Closed
@edmundmiller edmundmiller self-assigned this Aug 28, 2023
@edmundmiller edmundmiller added this to the 2.5.0 milestone Aug 28, 2023
@edmundmiller edmundmiller marked this pull request as draft August 29, 2023 03:20
@edmundmiller edmundmiller marked this pull request as ready for review October 17, 2023 08:44
@edmundmiller edmundmiller merged commit b5727f7 into dev Oct 17, 2023
9 checks passed
@edmundmiller edmundmiller deleted the schema-exists branch October 18, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

@FelixKrueger FelixKrueger Awaiting requested review from FelixKrueger

Assignees

@edmundmiller edmundmiller

Labels
None yet
Projects
No open projects
Hackathon: November 2023
Status: Done
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@edmundmiller @sateeshperi