Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR for 3.0.3 #656

Merged
merged 38 commits into from
Aug 27, 2024
Merged

Release PR for 3.0.3 #656

merged 38 commits into from
Aug 27, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Aug 22, 2024

Patch release for a variety of bugs:

  • #648 - Fix sample ID/assembly ID check failure when no IDs match (reported by @zackhenny, fix by @prototaxites)
  • #646 - GTDB-Tk directory input now creates a value channel so it runs for all entries to the process and not just the first (reported by @amizeranschi, fix by @prototaxites).
  • #639 - Fix pipeline failure when a sample produces only a single bin (fix by @d-callan)
  • #651 - Replace base container for bash only modules to reduce number of containers in pipeline (reported and fixed by @harper357)
  • #652 - Fix documentation typo in using user-defined assembly parameters (reported and fixed by @amizeranschi)
  • #653 - Fix overwriting of per-bin 'raw' GUNC RUN output files (multi-bin summary tables not affected) (reported by @zackhenny and fixed by @jfy133)

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

jfy133 and others added 30 commits July 4, 2024 08:41
Co-authored-by: James A. Fellows Yates <[email protected]>
Co-authored-by: James A. Fellows Yates <[email protected]>
Fix match check of assembly and sample IDs
Fix #638 [MAG_DEPTHS_PLOT fails if only a single bin is produced]
Remove "=" sign from parameter value assignment
Change unnecessary MultiQC containers to nf-core/ubuntu:20.04
Copy link

github-actions bot commented Aug 22, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f629418

+| ✅ 305 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   6 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.0.3
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-08-27 07:54:28

subworkflows/local/depths.nf Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 jfy133 merged commit 8e3f760 into master Aug 27, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants