Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.9 #467

Merged
merged 7 commits into from
Jul 7, 2023
Merged

Important! Template update for nf-core/tools v2.9 #467

merged 7 commits into from
Jul 7, 2023

Conversation

nf-core-bot
Copy link
Member

Version 2.9 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.9 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/developers/sync.

For more information about this release of nf-core/tools, please see the v2.9 release page.

@jfy133 jfy133 self-requested a review July 6, 2023 09:24
@github-actions
Copy link

github-actions bot commented Jul 6, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7456c04

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-06 13:42:59

jfy133
jfy133 reviewed Jul 6, 2023
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
@jfy133 jfy133 mentioned this pull request Jul 6, 2023
Merged
9 tasks
@jfy133 jfy133 self-requested a review July 6, 2023 12:58
@maxulysse
Copy link
Member

Wait, you're approving your own changes?

that feels familiar

maxulysse
maxulysse reviewed Jul 6, 2023
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
JoseEspinosa
JoseEspinosa approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jfy133
Copy link
Member

jfy133 commented Jul 6, 2023

Wait, you're approving your own changes?

that feels familiar

No no no, approving the bots changes 😏

@jfy133 @maxulysse
Update nextflow.config
2886459 
Co-authored-by: Maxime U Garcia <[email protected]>
@jfy133 jfy133 requested a review from maxulysse July 6, 2023 13:35
@jfy133 jfy133 merged commit ad596b0 into dev Jul 7, 2023
@jfy133 jfy133 deleted the nf-core-template-merge-2.9 branch July 7, 2023 06:51
@jfy133 jfy133 restored the nf-core-template-merge-2.9 branch July 7, 2023 06:51
@jfy133 jfy133 deleted the nf-core-template-merge-2.9 branch July 7, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nf-core-bot @maxulysse @jfy133 @JoseEspinosa