Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch release 1.1.2 with bug fix #137

Merged
merged 18 commits into from
Nov 24, 2020
Merged

Patch release 1.1.2 with bug fix #137

merged 18 commits into from
Nov 24, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Nov 24, 2020 •
edited
Loading

Release 1.1.2 with bug fix concerning processing of --input parameter (#131).

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

skrakau and others added 18 commits November 18, 2020 10:06
@skrakau
Bump 1.2.0dev
694d3e1
@skrakau
Update CHANGELOG
02110dd
@skrakau
Adjusted GitHub actions workflows
47da0bb
@skrakau
Swithced env.GIT_DIFF to env.MATCHED_FILES in ci.yml
ba34860
@skrakau
Merge pull request #132 from skrakau/bump_1.2.0dev_2
98d5aa0 
Bump 1.2.0dev
@skrakau
Fix processing of input parameter.
9a59db6
@skrakau
Initialize input_paths variable to avoid warning for users if not set
a6baf63
@skrakau
Update CHANGELOG
e07a04e
@nf-core-bot
Template update for nf-core/tools version 1.12
cb8e69f
@skrakau
Merge pull request #133 from skrakau/fix_input
e26244b 
Fix processing of input parameter
@skrakau
Merge branch 'TEMPLATE' of https://github.com/nf-core/mag into merge-…
da39bca 
…template-1.12
@skrakau
Update CHANGELOG
2ee1f47
@skrakau
Adjust push_dockerhub
2250e14
@skrakau @drpatelh
Update main.nf
8fca699 
Co-authored-by: Harshil Patel <[email protected]>
@skrakau
Merge pull request #135 from skrakau/merge-template-1.12
d4f9888 
Merge nf-core template 1.12
@skrakau
Update CHANGELOG
0974dca
@skrakau
Bump version 1.1.2
07dd281
@skrakau
Merge pull request #136 from skrakau/prep_release_1.1.2
6f22808 
Prepare release 1.1.2
@skrakau skrakau requested a review from d4straub November 24, 2020 14:35
@skrakau skrakau marked this pull request as ready for review November 24, 2020 14:36
d4straub
d4straub approved these changes Nov 24, 2020
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not identify any issue!

ggabernet
ggabernet approved these changes Nov 24, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@skrakau
Copy link
Member Author

skrakau commented Nov 24, 2020

Thanks for reviewing @d4straub and @ggabernet !

@skrakau skrakau merged commit 8c0f1fe into master Nov 24, 2020
@skrakau skrakau changed the title Minor release 1.1.2 with bug fix Patch release 1.1.2 with bug fix Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@ggabernet ggabernet ggabernet approved these changes

@KevinMenden KevinMenden Awaiting requested review from KevinMenden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrakau @ggabernet @d4straub @nf-core-bot