Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split ancientDNA sub-workflow into separate sub-workflows for running damage analysis and consensus correction #456

Closed
alexhbnr opened this issue Jun 14, 2023 · 0 comments · Fixed by #459
Assignees
Labels
enhancement New feature or request

Comments

@alexhbnr
Copy link
Contributor

alexhbnr commented Jun 14, 2023

Description of feature

Currently, enabling the ancientDNA workflow automatically enables the correction of the consensus sequence reported by the de novo assembler and the analysis of the presence of ancient DNA damage. The first step is mainly driven by the issue that we observed that MEGAHIT generates contig sequences that are riddled with nonsense mutations or stop codons when ancient DNA damage is present but were not supported by the short-read data.

When assembling with metaSPAdes, we do not observe such a behaviour and therefore the consensus correction might not be necessary. However, we still would like to run the evaluation of the amount of aDNA damage present using pyDamage.

It would be very helpful, if the two modules in this sub-workflow could be separated from each other, so they can be switched on and off separately.

@alexhbnr alexhbnr added the enhancement New feature or request label Jun 14, 2023
@jfy133 jfy133 self-assigned this Jun 15, 2023
@jfy133 jfy133 linked a pull request Jun 16, 2023 that will close this issue
9 tasks
@jfy133 jfy133 closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants