Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] thumbnails simply don't work #41

Open
nexy7574 opened this issue Jan 20, 2025 · 3 comments
Open

[BUG] thumbnails simply don't work #41

nexy7574 opened this issue Jan 20, 2025 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nexy7574
Copy link
Owner

Describe the bug
Thumbnails generated for videos end up in some nested mess and in the end usually don't even display, and sometimes even break clients with strict spec adherence.

To Reproduce
Send a VideoAttachment with an auto generated thumbnail

Expected behavior
Thumbnail generates and is attached properly

@nexy7574 nexy7574 added the bug Something isn't working label Jan 20, 2025
@nexy7574 nexy7574 added this to the v1.3.0 milestone Jan 20, 2025
@nexy7574 nexy7574 self-assigned this Jan 20, 2025
@fd1f
Copy link

fd1f commented Jan 20, 2025

{
  "content": {
    "body": "tmpc2s89674.mp4",
    "filename": "tmpc2s89674.mp4",
    "info": {
      "duration": 20501,
      "h": 1080,
      "mimetype": "video/mp4",
      "size": 13203091,
      "thumbnail_info": {
        "h": 1080,
        "mimetype": "image/webp",
        "size": 5952,
        "thumbnail_info": {
          "h": 240,
          "mimetype": "image/webp",
          "size": 1212,
          "w": 135
        },
        "thumbnail_url": null,
        "w": 608,
        "xyz.amorgan.blurhash": "LTF=:axtofof_NayRjRktSoejZj["
      },
      "thumbnail_url": null,
      "w": 608
    },
    "m.new_content": {
      "body": "tmpc2s89674.mp4",
      "filename": "tmpc2s89674.mp4",
      "info": {
        "duration": 20501,
        "h": 1080,
        "mimetype": "video/mp4",
        "size": 13203091,
        "thumbnail_info": {
          "h": 1080,
          "mimetype": "image/webp",
          "size": 5952,
          "thumbnail_info": {
            "h": 240,
            "mimetype": "image/webp",
            "size": 1212,
            "w": 135
          },
          "thumbnail_url": null,
          "w": 608,
          "xyz.amorgan.blurhash": "LTF=:axtofof_NayRjRktSoejZj["
        },
        "thumbnail_url": null,
        "w": 608
      },
      "msgtype": "m.video",
      "url": null
    },
    "m.relates_to": {
      "event_id": "$3CVo0zEF7tAHHKNtFW2lk5kU5nFfRnVVFJiZau4v5qU",
      "m.rel_type": "m.replace"
    },
    "msgtype": "m.video",
    "url": null
  },
  "event_id": "$XFQNi6EeG6PkfaIw_eLvxrDC2-0eMkpy_C3IPlhdmTA",
  "origin_server_ts": 1737344170458,
  "sender": "@nonsensebot:nexy7574.co.uk",
  "type": "m.room.message",
  "unsigned": {
    "age": 1608
  },
  "room_id": "!general-v2:nexy7574.co.uk"
}

@nexy7574
Copy link
Owner Author

Danke

@nexy7574
Copy link
Owner Author

Should have been fixed in c1fbfc3, just needs some testing for confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants