You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add an option to extend the default mappings in addition to the existing behavior of replacing them.
For entries in both, the extending file should take precedence over the default.
Why?
The current behavior has encouraged curation of lat/long values independently across pathogen repos, rather than in a centralized place. Due to increased attention during the SARS-CoV-2 pandemic, the ncov workflow has a carefully curated lat/longs file. A recent PR #1449 moved all that effort into Augur's default mapping, however at this point a significant amount of pathogen repos already have their own lat/longs files.
Proposed solutions
These are based on my speculation that most pathogen repos would benefit from extending rather than overriding – I could be wrong.
1. Switch behavior directly
Make --lat-longs extend instead of replace defaults in a major release.
2. Switch behavior with deprecation
Add an option --lat-longs-extend with this new additive behavior.
Link the current option --lat-longs to a new name --lat-longs-override with a deprecation warning that the behavior of --lat-longs will switch to --lat-longs-extend in the future.
Switch --lat-longs behavior to --lat-longs-extend in a major version release.
The text was updated successfully, but these errors were encountered:
+1 for Appending user-provided data onto the defaults. This is how --colors works.
What's the downside to switching the behaviour of --lat-longs in a single step? For a repo with their own lat-longs file then there will be no change unless they are missing some which will now be filled in by the defaults, and the only reason this wouldn't be desirable is if they are using missing lat-longs as a hack to avoid plotting certain demes on the map. I'd suggest changing the behaviour of --lat-longs now (with a major version release).
Context
Currently,
--lat-longs
overrides the default mappings provided by augur/data/lat_longs.tsv.Description
Add an option to extend the default mappings in addition to the existing behavior of replacing them.
For entries in both, the extending file should take precedence over the default.
Why?
The current behavior has encouraged curation of lat/long values independently across pathogen repos, rather than in a centralized place. Due to increased attention during the SARS-CoV-2 pandemic, the ncov workflow has a carefully curated lat/longs file. A recent PR #1449 moved all that effort into Augur's default mapping, however at this point a significant amount of pathogen repos already have their own lat/longs files.
Proposed solutions
These are based on my speculation that most pathogen repos would benefit from extending rather than overriding – I could be wrong.
1. Switch behavior directly
--lat-longs
extend instead of replace defaults in a major release.2. Switch behavior with deprecation
--lat-longs-extend
with this new additive behavior.--lat-longs
to a new name--lat-longs-override
with a deprecation warning that the behavior of--lat-longs
will switch to--lat-longs-extend
in the future.--lat-longs
behavior to--lat-longs-extend
in a major version release.The text was updated successfully, but these errors were encountered: