Enable tests for PRs that don't merge into main or develop #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwallwork23
commented
Jan 6, 2025
| @@ -4,7 +4,6 @@ on: | |||
| push: | |||
| branches: [ main, develop ] | |||
| pull_request: | |||
| branches: [ main, develop ] | |||
There was a problem hiding this comment.
@TomMelt to look into draft PRs. If not, add a comment here for how to ignore certain branches.
TomMelt
force-pushed
the
issue764_testing-not-main-or-develop
branch
from
6a91857 to
af56639
Compare
AdelekeBankole
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
@TomMelt, thank you. This looks good to me at least from what I picked up from yesterday's meeting.
TomMelt
force-pushed
the
issue764_testing-not-main-or-develop
branch
from
ac9d672 to
f8b5d84
Compare
See comments in `.github/workflows/test_suite.yml` for more info.
TomMelt
force-pushed
the
issue764_testing-not-main-or-develop
branch
from
f8b5d84 to
42cac55
Compare
|
@timspainNERSC , I just raised #769 because I realised I could merge without the tests running at all. We should be able to fix this next meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #764
Closes #769
I recommend we use this approach described here i.e.,:
I think we should avoid editing
.github/workflows/test_suite.yml.There is another popular approach using something like
if: github.event.pull_request.draft == falsein the workflow, but this comes with many problems. See here for more info.