Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] "Reload Resource" button does not update library file if the library file name has not changed #5254

Open
beau-ronin opened this issue Jun 22, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@beau-ronin
Copy link

beau-ronin commented Jun 22, 2022

Describe the bug
When reloading .jar files into resources, we found that if the name of the file did not change (despite being a new version of the file), the Reload Resource button would not pull in the new version.

Expected behavior
Reloading pulls in the files without worrying about the name.

Actual behavior
Seems that reloading still hits the cache somehow

I expect the issue is in DefaultContextFactoryController.java, perhaps here where 'reload' is hardcoded to false.
private void resetContextFactory(Set<String> libraryResourceIds, boolean startup) throws Exception { logger.debug("Resetting context factory: libraryResourceIds=" + String.valueOf(libraryResourceIds)); List<URL> libraries = getLibraries(libraryResourceIds, false, startup);

@beau-ronin beau-ronin added the bug Something isn't working label Jun 22, 2022
@beau-ronin
Copy link
Author

Update: could potentially be caused by this Docker issue instead: docker/for-mac#6219

@jonbartels
Copy link
Contributor

What is the minimum way to reproduce this problem?

Create a JAR with a simple public void getFoo() method that returns a string. Test that in a channel. Then recompile the JAR to return a different string and reload it. Then on execution it would return the same string. Does that process sound like the right repro steps?

@beau-ronin
Copy link
Author

Yes, that sounds like exactly what I tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants