-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Job priority #93
Comments
Good point @matthdsm, I see that there is some correlation between the Nomad server side setting https://developer.hashicorp.com/nomad/docs/configuration/server#job_max_priority What's the limit you guys are using on the cluster? |
@tomiles? Any idea? |
For now it's just default = |
Agreed @tomiles , we'd just need to find a way to inspect this value from a Nomad job, otherwise the mismatch between the job submission priority and the server level setting could lead to underfined behavior. @matthdsm , could you please do a quick check for this behavior using vanilla nomad job with out-of-bound priority? |
I think the API should give you an exemption when you try to run the job with invalid (out of bounds) priority. So we probably don't need to go and replicate checks nomad server does for you, and just properly catch API errors. |
@abhi18av are you working in this or do you want I take a look? |
Hi dear @jagedn and team 👋 Apologies for the radio silence but I'm afraid, I'll only be able to (consistently) resume my tasks once I'm back home in SA. If anyone can take this forward that'd be great! 🙏 At the moment, I'm in Brazil for organizing training events in different sites. Ideally we will start deploying the plugin and site-specific Nomad clusters in these locations where the trainings are being done as of now. |
I founded this endpoint interesting: we can run a dummy plan at startup for a job with a very high priority and parse the error from the server ... but at this point I don't know what's your idea. I mean, do we need to validate the priority of a process before to submit and abort the pipeline ? if exceeded do we need to change it ? .... |
meantime I'll implement the priority annotation |
@abhi18av You have a great challenge ahead of you: |
@matthdsm I just uploaded 0.3.2-edge2 with a new optional In case you exceed the max priority configured in the server the job will fail (I think) https://github.com/nextflow-io/nf-nomad/releases/tag/0.3.2-edge2 |
Hi guys,
Would it be feasible to implement an option for job priority? We've got a workload on our cluster that has to take priority over other batch jobs.
I'm thinking an extra option for the process configuration would be nice?
Cheers
Matthias
The text was updated successfully, but these errors were encountered: