Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package ID warnings and error(s) querying package graph on most-recent nightly runs #1232

Closed
zeeshanlakhani opened this issue Jan 18, 2024 · 4 comments

Comments

@zeeshanlakhani
Copy link

zeeshanlakhani commented Jan 18, 2024

Firstly, just wanted to give a ❤️ and thank you for this project!

Note: This started with the latest version of Rust nightly.

nightly-x86_64-apple-darwin unchanged - rustc 1.77.0-nightly (6ae4cfbbb 2024-01-17)

It does not happen on stable.

After compilation, we get a series of dependency-related warnings like package ID names 0.14.0 (registry+[https://github.com/rust-lang/crates.io-index)](https://github.com/rust-lang/crates.io-index)) which wasn't produced by cargo metadata. Then, as one example, it errors out with:

error: failed to parse messages generated by Cargo

Caused by:
  error querying package graph

Caused by:
  unknown package ID: homestar-functions-add 0.1.0 (path+file:///home/runner/work/homestar/homestar/homestar-functions/add)

This also occurs for me locally with the latest nightly release.

Link to CI Github Action(s): https://github.com/ipvm-wg/homestar/actions/runs/7569332335/job/20612405047?pr=506#step:10:1505

@Tom-Goring
Copy link

Tom-Goring commented Jan 18, 2024

Getting the same thing on internal CI + local tests on 1.77.0-nightly (6ae4cfbbb 2024-01-17).

I did get a working test yesterday on 1.77.0-nightly (098d4fd74 2024-01-16) so presumably it's today's nightly that caused this?

@zeeshanlakhani
Copy link
Author

@Tom-Goring yep, seems to be the most recent 01-17 nightly.

@lvyitian
Copy link

This might be caused by:rust-lang/cargo#12914
And it should be fixed by:rust-lang/cargo#13311

@sunshowers
Copy link
Member

Yes, I believe @lvyitian is correct. We treat package IDs as opaque generally so the format change itself isn't a problem. However, we match up the package IDs from cargo metadata with the ones from JSON messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants