-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server crashed, regular cleanups, improve configs, etc... #306
base: main
Are you sure you want to change the base?
Conversation
I know it is in draft and I haven't checked the code yet, but maybe you can provide a short summary on why it crashed and how the fix changes that to the PR description :) |
2def488
to
fb9f2f1
Compare
fb9f2f1
to
8082534
Compare
8082534
to
d127ab3
Compare
Picking configs, constants improvements from https://github.com/nextcloud/whiteboard/pull/226/files for not blocking merge |
8262a7a
to
96994a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment, otherwise that looks good 👍
96994a8
to
b97985f
Compare
Signed-off-by: Hoang Pham <[email protected]>
b97985f
to
434437d
Compare
Co-authored-by: Julius Knorr <[email protected]> Signed-off-by: Hoang Pham <[email protected]>
Issue
The whiteboard server crashes after running for 25+ minutes (#258) due to:
=> Mostly because of the LRU cache evicting data while the socket connection is still alive
(My mistake for not separate the storage of Rooms Data and socket/session data)
Fix