Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable previous / next video preloading #2284

Open
olaulau opened this issue Apr 4, 2024 · 8 comments
Open

disable previous / next video preloading #2284

olaulau opened this issue Apr 4, 2024 · 8 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request

Comments

@olaulau
Copy link

olaulau commented Apr 4, 2024

Is your feature request related to a problem? Please describe.
when playing some high rate video (from a gopro for example), with many in the same folder, the viewer preloads simultaneously the previous and the next video, which can be very laggy.

Describe the solution you'd like
we could :

  • totally disable video preloading there :
    preload="metadata"
  • disable preloading for previous / next video only
  • only preload after a while, when the current video is buffered and already playing
  • have a setting that allows user to disable this globally, or maybe per folder

Describe alternatives you've considered
I don't really know how to develop with vue.js and compile this sources, but I figured out this workaround :

  • in nextcloud dir, edit : apps/viewer/js/viewer-main.js
  • find {ref:"video",attrs:{autoplay:!!e.active||null,playsinline:!0,poster:e.livePhotoPath,src:e.src,preload:"metadata"}
  • change "metadata" to "none"
    we can see in FF network debugger that only one video file is requested (before we could see 3 different videos requested)

Additional context
it is not a cpu problem, my hosting server is ok, it's really a bandwidth problem, which is felt more from internet than locally.

@olaulau olaulau added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request labels Apr 4, 2024
@DGideas
Copy link

DGideas commented Jul 9, 2024

Agree, I have lots of videos on a 100Mbps server with Nextcloud, and I observed very poor performance when previewing these videos. However, there is no problem when using the sharing link to view a single video file.

PS. I use this Nextcloud instance which only have 1 user

@skjnldsv
Copy link
Member

skjnldsv commented Jul 9, 2024

Preload metadata should only load a few KB of video, I'm surprised that has such a big effect on your servers.

I have lots of videos on a 100Mbps server

Well, that would epxlain it, 100mbps is really low for a server serving videos :/

@olaulau
Copy link
Author

olaulau commented Jul 9, 2024

Preload metadata should only load a few KB of video, I'm surprised that has such a big effect on your servers.

it does not load only metadata but the whole video

I have lots of videos on a 100Mbps server

Well, that would epxlain it, 100mbps is really low for a server serving videos :/

it's not a slow host if you have only one user.
and I had same problem with a great host and a 700M uplink !

@skjnldsv
Copy link
Member

Is any of you in Nextcloud 29 ?

@skjnldsv
Copy link
Member

@olaulau what is the total size downloaded by your browser on the preloaded videos?
For me it reaches maybe 1-2MB max 🤔

@olaulau
Copy link
Author

olaulau commented Jul 26, 2024

migrated to nextcloud hub 8 (29.0.3).
still loading 3 different video files.
when the video starts playing, browser has already loaded more that 100MB (cleared the network view and filtering only media type)

@skjnldsv
Copy link
Member

100MB from videos other than the current one you mean?

@olaulau
Copy link
Author

olaulau commented Jul 26, 2024

yes, filtering with current file shows only a third of total media transferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants