fixup! Add support for non-dav files

Signed-off-by: Christoph Wurst <[email protected]>

cypress/e2e/non-dav-files.cy.js

@@ -40,7 +40,7 @@ describe('Open non-dav files in viewer', function() {
 	it('Open login background', function() {
 		const fileInfo = {
 			filename: '/core/img/logo/logo.png',
-			basename: '/core/img/logo',
+			basename: 'logo.png',
 			mime: 'image/png',
 			source: '/core/img/logo/logo.png',
 			etag: 'abc',
@@ -54,7 +54,23 @@ describe('Open non-dav files in viewer', function() {
 				list: [fileInfo],
 			})
 		})
+	})
+
+	it('Does not see a loading animation', function() {
+		cy.get('body > .viewer', { timeout: 10000 })
+			.should('be.visible')
+			.and('have.class', 'modal-mask')
+			.and('not.have.class', 'icon-loading')
+	})
 
+	it('See the menu icon and title on the viewer header', function() {
+		cy.get('body > .viewer .modal-title').should('contain', 'logo.png')
+		cy.get('body > .viewer .modal-header button.action-item__menutoggle').should('be.visible')
 		cy.get('body > .viewer .modal-header button.header-close').should('be.visible')
 	})
+
+	it('Does not see navigation arrows', function() {
+		cy.get('body > .viewer a.prev').should('not.be.visible')
+		cy.get('body > .viewer a.next').should('not.be.visible')
+	})
 })

cypress/e2e/visual-regression.cy.js

@@ -89,7 +89,7 @@ describe('Visual regression tests ', function() {
 		cy.get('body > .viewer a.next').click()
 		cy.get('body > .viewer .modal-container img').should('have.length', 1)
 		cy.get('body > .viewer .modal-container img').should('have.attr', 'src')
-		cy.get('body > .viewer a.next').should('be.visible')
+		cy.get('body > .viewer a.prev').should('be.visible')
 		cy.get('body > .viewer a.next').should('be.visible')
 	})
 
@@ -112,7 +112,7 @@ describe('Visual regression tests ', function() {
 		cy.get('body > .viewer .modal-title').should('contain', 'test-card.png')
 		cy.get('body > .viewer .modal-container img').should('have.length', 1)
 		cy.get('body > .viewer .modal-container img').should('have.attr', 'src')
-		cy.get('body > .viewer a.next').should('be.visible')
+		cy.get('body > .viewer a.prev').should('be.visible')
 		cy.get('body > .viewer a.next').should('be.visible')
 	})
 
@@ -127,10 +127,10 @@ describe('Visual regression tests ', function() {
 		cy.compareSnapshot('image2')
 	})
 
-	it('Take non-dav file screenshot', function() {
+	it('Open non-dav image', function() {
 		const fileInfo = {
 			filename: '/core/img/logo/logo.png',
-			basename: '/core/img/logo',
+			basename: 'logo.png',
 			mime: 'image/png',
 			source: '/core/img/logo/logo.png',
 			etag: 'abc',
@@ -145,6 +145,20 @@ describe('Visual regression tests ', function() {
 			})
 		})
 
+		cy.get('body > .viewer .modal-container img').should('have.length', 1)
+		cy.get('body > .viewer .modal-container img').should('have.attr', 'src')
+		cy.get('body > .viewer a.prev').should('not.be.visible')
+		cy.get('body > .viewer a.next').should('not.be.visible')
+	})
+
+	it('Does not see a loading animation', function() {
+		cy.get('body > .viewer', { timeout: 10000 })
+			.should('be.visible')
+			.and('have.class', 'modal-mask')
+			.and('not.have.class', 'icon-loading')
+	})
+
+	it('Take non-dav logo.png screenshot', function() {
 		cy.compareSnapshot('non-dav')
 	})
 })

src/components/ImageEditor.vue

@@ -106,7 +106,7 @@ export default {
 			return {
 				'data-theme-dark': true,
 			}
-		}
+		},
 	},
 
 	mounted() {

src/views/Viewer.vue

@@ -494,7 +494,7 @@ export default {
 				// retrieve folder list
 				const { request: folderRequest, cancel: cancelRequestFolder } = cancelableRequest(getFileList)
 				this.cancelRequestFolder = cancelRequestFolder
-				const [dirPath,] = extractFilePaths(fileInfo.filename)
+				const [dirPath] = extractFilePaths(fileInfo.filename)
 				const fileList = await folderRequest(dirPath)
 
 				// filter out the unwanted mimes