Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve iterators #516

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Improve iterators #516

wants to merge 2 commits into from

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Nov 9, 2023

Ref #507

Initial work in #90

Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim self-assigned this Nov 9, 2023
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@blizzz
Copy link
Member

blizzz commented Nov 23, 2023

Please don't forget to set the milestone when opening a PR 😃

@tovine
Copy link

tovine commented May 27, 2024

What's the outlook on the timeline for this one? I just had an update basically time out and break itself when I decided to look at the updater code - only to find out that it recurses through all files (including user data and old backups) before doing the filtering.
My server is basically stuck at creating backup for an hour, with the apache process disk-limited at 2% CPU usage and about ~250kB/s read. This pull request looks like it should fix all that and make updating Nextcloud bearable again... 🙏

@Altahrim
Copy link
Collaborator Author

No timeline as I don't find time to work on this…
As a workaround you can do a backup manually and use the --no-backup option in the updater

@doits
Copy link

doits commented Jun 2, 2024

As a workaround you can do a backup manually and use the --no-backup option in the updater

Even with this flag it still hangs/iterates at "Delete old files ..." unfortunately, so it is only a partial solution. (My updates take 1+ hour, too.)

@tovine
Copy link

tovine commented Jun 11, 2024

No timeline as I don't find time to work on this… As a workaround you can do a backup manually and use the --no-backup option in the updater

Understandable.
Is there much left to be done or is it just a matter of testing?

@doits
Copy link

doits commented Jun 11, 2024

My last update from 29.0.1 to 29.0.2 was much faster though (still with --no-backup)! Only took very few minutes for the "Delete old files ..." step (didn't pay attention to exactly how long because I thought it will run for 1+ hour but it finished much much quicker). Coincidence or was something merged between those releases that made this much faster? I'm puzzled.

@tovine
Copy link

tovine commented Sep 17, 2024

Is there a way I can test this fix on my own instance? Looks like the change should work and be safe enough so I'd like to give it a try if possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants