fix: catch expected exception in event handler #5497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
mejo-
approved these changes
Mar 17, 2024
This was referenced Mar 20, 2024
mejo-
added a commit
that referenced
this pull request
Mar 25, 2024
* Add the scroll event listener to the app details pane, not to document * Don't dispatch the scroll event in capture phase Fixes: #5497 Signed-off-by: Jonas <[email protected]>
2 tasks
mejo-
added a commit
that referenced
this pull request
Mar 25, 2024
Don't hide e.g. when scrolling in an input element. Fixes: #5497 Signed-off-by: Jonas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #5481 which otherwise might cause an error being thrown during normal file operations where we should just ignore this case.
Found on our instance