fix: Call to a member function getUserId() on bool #4170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Git'Fellow <[email protected]>
1 flaky tests on run #9809 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Sync > recovers from a lost connection |
Output
Screenshots
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
juliusknorr
reviewed
May 15, 2023
| $this->userToRestore = $this->userSession->getUser(); | ||
| $this->userSession->setUser($user); | ||
| $userId = $currentSession->getUserId(); | ||
| if ($userId !== false) { |
There was a problem hiding this comment.
I'm curious how we end up with a boolean here, since this should rather be null
There was a problem hiding this comment.
Line 47 in 4fce40b
There was a problem hiding this comment.
Do you have an exception trace or error log of this being an issue?
There was a problem hiding this comment.
{
"reqId": "6ir0CrrQgBReHnset6dX",
"level": 3,
"time": "2023-05-12T18:31:27+02:00",
"remoteAddr": "195.20.18.18",
"user": "elith.breur",
"app": "index",
"method": "POST",
"url": "/apps/text/session/sync",
"message": "Call to a member function getUserId() on bool in file '/var/www/nextcloud/apps/text/lib/Controller/SessionController.php' line 111",
"userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/113.0.0.0 Safari/537.36",
"version": "24.0.12.1",
"exception": {
"Exception": "Exception",
"Message": "Call to a member function getUserId() on bool in file '/var/www/nextcloud/apps/text/lib/Controller/SessionController.php' line 111",
"Code": 0,
"Trace": [
{
"file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
"line": 172,
"function": "dispatch",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
[
"OCA\\Text\\Controller\\SessionController"
],
"sync"
]
},
{
"file": "/var/www/nextcloud/lib/private/Route/Router.php",
"line": 298,
"function": "main",
"class": "OC\\AppFramework\\App",
"type": "::",
"args": [
"OCA\\Text\\Controller\\SessionController",
"sync",
[
"OC\\AppFramework\\DependencyInjection\\DIContainer"
],
[
"text.Session.sync"
]
]
},
{
"file": "/var/www/nextcloud/lib/base.php",
"line": 1030,
"function": "match",
"class": "OC\\Route\\Router",
"type": "->",
"args": [
"/apps/text/session/sync"
]
},
{
"file": "/var/www/nextcloud/index.php",
"line": 36,
"function": "handleRequest",
"class": "OC",
"type": "::",
"args": []
}
],
"File": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
"Line": 165,
"Previous": {
"Exception": "Error",
"Message": "Call to a member function getUserId() on bool",
"Code": 0,
"Trace": [
{
"file": "/var/www/nextcloud/apps/text/lib/Controller/SessionController.php",
"line": 105,
"function": "loginSessionUser",
"class": "OCA\\Text\\Controller\\SessionController",
"type": "->",
"args": [
"*** sensitive parameters replaced ***"
]
},
{
"file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
"line": 225,
"function": "sync",
"class": "OCA\\Text\\Controller\\SessionController",
"type": "->",
"args": [
"*** sensitive parameters replaced ***",
"*** sensitive parameters replaced ***",
"*** sensitive parameters replaced ***",
0,
null,
false,
false
]
},
{
"file": "/var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php",
"line": 133,
"function": "executeController",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
[
"OCA\\Text\\Controller\\SessionController"
],
"sync"
]
},
{
"file": "/var/www/nextcloud/lib/private/AppFramework/App.php",
"line": 172,
"function": "dispatch",
"class": "OC\\AppFramework\\Http\\Dispatcher",
"type": "->",
"args": [
[
"OCA\\Text\\Controller\\SessionController"
],
"sync"
]
},
{
"file": "/var/www/nextcloud/lib/private/Route/Router.php",
"line": 298,
"function": "main",
"class": "OC\\AppFramework\\App",
"type": "::",
"args": [
"OCA\\Text\\Controller\\SessionController",
"sync",
[
"OC\\AppFramework\\DependencyInjection\\DIContainer"
],
[
"text.Session.sync"
]
]
},
{
"file": "/var/www/nextcloud/lib/base.php",
"line": 1030,
"function": "match",
"class": "OC\\Route\\Router",
"type": "->",
"args": [
"/apps/text/session/sync"
]
},
{
"file": "/var/www/nextcloud/index.php",
"line": 36,
"function": "handleRequest",
"class": "OC",
"type": "::",
"args": []
}
],
"File": "/var/www/nextcloud/apps/text/lib/Controller/SessionController.php",
"Line": 111
},
"CustomMessage": "--"
},
"id": "6461e4a78f770"
}
There was a problem hiding this comment.
The trace looks like it's from a Nextcloud 24 install. So we need to reference the stable24 branch to see the actual code.
This exception originates here:
https://github.com/nextcloud/text/blob/stable24/lib/Controller/SessionController.php#L111
Here $currentSession is undefined. We already have a fix for this with the check in line 119.
There was a problem hiding this comment.
Looks like the issue in this trace was fixed in 6640ad2
could you try upgrading to Nextcloud 25 and see if that fixes it?
There was a problem hiding this comment.
Okay. Upgrade is planned with 25.0.7, will report back.
max-nextcloud
requested changes
May 23, 2023
|
Let's close this for now. @solracsf Feel free to reopen and adjust if there is a related fix for the main branch still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Check that
$currentSessionis not false before trying to retrieve the user.🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)