feat: unify header

[luka-nextcloud]

Signed-off-by: Luka Trovic [email protected]

• Resolves: Unified header #82
• Target version: master

Summary

unified-header-update.mov

[vinicius73]

I've sent some comments.

Please, check the ESLint warnings

[cypress]

---

Test summary

86 • 30 • 0 • 0 • 1

---

Run details

Project	Text
Status	Failed
Commit	a81c8c3
Started	Jan 11, 2023 3:06 PM
Ended	Jan 11, 2023 3:17 PM
Duration	11:26 💡
OS	Linux Ubuntu -
Browser	Electron 106

View run in Cypress Dashboard ➡️

---

Failures

	workspace.spec.js		7
1	Workspace > formats text
2	Workspace > creates headings via submenu
3	Workspace > creates lists
4	Workspace > emoji picker
5	Workspace > relative folder links
6	Workspace > callouts > create callout
7	Workspace > callouts > toggle callouts
	attachments.spec.js		1
1	Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side
	shortcuts.spec.js		2
1	keyboard shortcuts > bold
2	keyboard shortcuts > italic
This comment includes only the first 10 test failures. See all 30 failures in the Cypress Dashboard.

---

Flakiness

	cypress/e2e/conflict.spec.js		1
1	Open test.md in viewer > displays conflicts

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[luka-nextcloud]

@juliushaertl I've uploaded a video to show the status.

[juliusknorr]

@luka-nextcloud I think we agreed on trying to use portal-vue as a way to not re-implement the header bar, but instead try to only inject the menubar parts into the existing header.

#82 (comment)

If there have been any obstacles, maybe you can provide a summary of what you tried and why this didn't work.

This would be a flexible way to also take the mockups into account which are different for the logged in users where the viewer is used with the white header bar and the public share links that use the blue existing bar. We should try to avoid reimplementing the parts that are already in there by default like the close button/actions/download button.

[juliusknorr]

@luka-nextcloud Let me close this for now as it is on hold and needs a different approach anyways as we talked about the possible usage of vue-portal.