-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unified header #82
Comments
This comment has been minimized.
This comment has been minimized.
cc @skjnldsv as well regarding the Viewer app ^ |
I've moved the mockups to the first post and clarified the scope a bit since the original ticket was containing multiple things. Now this is purely about the unified header as the rest is already addressed. |
This comment has been minimized.
This comment has been minimized.
For the share link view, it would look even a bit nicer if we do it similar like in Nextcloud Office where there is only a thin primary line on the top, and the header "bar" is white. Then it’s not that huge of a contrast with a blue menu bar which is a bit uncommon. :) |
@juliushaertl I have some technical questions:
|
I'm wondering if we should actually rebuild the already existing UI or the option I would prefer is to find a way to inject the menubar and the avatars into the existing header. Not yet sure if that is technically feasible but maybe we could somehow trick the component to render into divs outside of the main text container. @vinicius73 Maybe you have a creative idea or can tell if that is a stupid idea :D One potential library for that I've found would be https://portal-vue.linusb.org |
@juliushaertl I did some research based on your suggestion: |
As just discussed in the call, I think we may dynamically insert an element to the div.header-left and then render the portal target into it similar to LinusBorg/portal-vue#114 (comment) |
Here are the mockups:
Unified bar Viewer + Text when logged in
We should also combine the Share icon and the avatars into one overlapped thing. When we have avatars, we don’t need a share icon at all, and they don’t need individual clickable area – all can open the sidebar.
For Shared links, even put the controls in the blue header bar
Desktop
Mobile
Smaller polishing before the rename (already done):
The text was updated successfully, but these errors were encountered: