Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified header #82

Open
2 of 5 tasks
juliusknorr opened this issue Jun 21, 2019 · 9 comments
Open
2 of 5 tasks

Unified header #82

juliusknorr opened this issue Jun 21, 2019 · 9 comments
Labels
2. developing design Experience, interaction, interface, … enhancement New feature or request upstream

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Jun 21, 2019

  • Combine viewer header and the text formatting menubar (similar to how it is done in Nextcloud Office now)
  • Combine the Share icon and the avatars into one overlapped thing. When we have avatars, we don’t need a share icon at all, and they don’t need individual clickable area – all can open the sidebar. (Mockup in the works)
  • For Shared links, even put the controls in the blue header bar – see Dropbox Paper. (Mockup in the works)

Here are the mockups:

Unified bar Viewer + Text when logged in

We should also combine the Share icon and the avatars into one overlapped thing. When we have avatars, we don’t need a share icon at all, and they don’t need individual clickable area – all can open the sidebar.
Text app desktop logged in header

For Shared links, even put the controls in the blue header bar

Desktop
Text app share link header bar desktop
Mobile
Text app header mobile new

Smaller polishing before the rename (already done):

  • Flash of half-transparent black at the beginning of viewer open should be white instead. Use viewer theme #1907
  • Title and icons on top right shouldn’t fade out
@juliusknorr juliusknorr added the design Experience, interaction, interface, … label Jun 21, 2019
@juliusknorr juliusknorr added this to the 2.0 📋 milestone Jun 21, 2019
@juliusknorr juliusknorr mentioned this issue Jun 21, 2019
7 tasks
@jancborchardt jancborchardt added enhancement New feature or request high labels Jun 21, 2019
@jancborchardt jancborchardt modified the milestones: 2.0 📋, 1.0 📜 Jun 24, 2019
@jancborchardt

This comment has been minimized.

@jancborchardt
Copy link
Member

cc @skjnldsv as well regarding the Viewer app ^

@juliusknorr
Copy link
Member Author

I've moved the mockups to the first post and clarified the scope a bit since the original ticket was containing multiple things. Now this is purely about the unified header as the rest is already addressed.

@szaimen

This comment has been minimized.

@jancborchardt
Copy link
Member

For the share link view, it would look even a bit nicer if we do it similar like in Nextcloud Office where there is only a thin primary line on the top, and the header "bar" is white. Then it’s not that huge of a contrast with a blue menu bar which is a bit uncommon. :)

@luka-nextcloud
Copy link
Contributor

@juliushaertl I have some technical questions:

  • How can I get shared by and download link from the text app since they exist in server app? How can we pass those values to text app?
  • How can we trigger the event to open the sidebar from the text app?

@juliusknorr
Copy link
Member Author

I'm wondering if we should actually rebuild the already existing UI or the option I would prefer is to find a way to inject the menubar and the avatars into the existing header.

Not yet sure if that is technically feasible but maybe we could somehow trick the component to render into divs outside of the main text container.

@vinicius73 Maybe you have a creative idea or can tell if that is a stupid idea :D

One potential library for that I've found would be https://portal-vue.linusb.org

@luka-nextcloud
Copy link
Contributor

@juliushaertl I did some research based on your suggestion:
First, we need to put a portal target on our header.
And then we need to wrap the menubar into the <Portal> component. That means we need to modify the nexcloud-vue library.
We need to modify both the text app and the nexcloud-vue.
Since the nextcloud-vue is a library, I don't think we can modify it and it seems not feasible...

@juliusknorr
Copy link
Member Author

As just discussed in the call, I think we may dynamically insert an element to the div.header-left and then render the portal target into it similar to LinusBorg/portal-vue#114 (comment)

@juliusknorr juliusknorr moved this from 📄 To do (5-20 entries) to 🏗️ In progress in 📝 Office team Jul 20, 2022
@juliusknorr juliusknorr moved this from 🏗️ In progress to 🛑 On hold in 📝 Office team Apr 14, 2023
@juliusknorr juliusknorr moved this from 🛑 On hold to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing design Experience, interaction, interface, … enhancement New feature or request upstream
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

Successfully merging a pull request may close this issue.

8 participants