Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar controls: bad UX #523

Closed
wiswedel opened this issue Jan 7, 2020 · 7 comments
Closed

Sidebar controls: bad UX #523

wiswedel opened this issue Jan 7, 2020 · 7 comments
Labels
design Experience, interaction, interface, … enhancement New feature or request

Comments

@wiswedel
Copy link

wiswedel commented Jan 7, 2020

At start there are 2 buttons:

  • Open sidebar
  • Close

After opening the sidebar, the Open sidebar button still has the tooltip Open sidebar, even though the sidebar is already open. Clicking on the button does nothing.

In order to close the sidebar however, you don't have to click on the nearby Close button, but on the close button within the sidebar. (side note: Close ≠ close --> case sensitivity)

Peek 2020-01-07 09-58

Here's my suggestion:

  1. Turn the Open sidebar button into a Close sidebar button once the sidebar is opened
  2. Make the icon consistent with the UX in richdocuments (Collabora):
    image
  3. Keep the Close button in the sidebar for the sake of consistency with other occasions' sidebar behavior
  4. Rename the inner Close button's tooltip to Close document
@wiswedel wiswedel added enhancement New feature or request design Experience, interaction, interface, … labels Jan 7, 2020
@juliusknorr
Copy link
Member

cc @nextcloud/designers as right now we still use the viewer app. However I was already thinking if we should just take care of the modal display manually as the sidebar can now be triggered individually. This would also help a lot with #82

@skjnldsv
Copy link
Member

skjnldsv commented Jan 7, 2020

@juliushaertl What is wrong with the sidebar being opened by the viewer?

@jancborchardt
Copy link
Member

Very related to nextcloud/viewer#328 in general.

Here's my suggestion:

  1. Turn the Open sidebar button into a Close sidebar button once the sidebar is opened

👍

  1. Make the icon consistent with the UX in richdocuments (Collabora):
    image

I’d say it should be the other way around, that icon should be adjusted.

  1. Keep the Close button in the sidebar for the sake of consistency with other occasions' sidebar behavior

Yep

  1. Rename the inner Close button's tooltip to Close document

👍


Additionally:

  • Do not show the preview part in the sidebar because it makes no sense to have a preview for the document you have open right next to it.

@wiswedel
Copy link
Author

wiswedel commented Jan 8, 2020

Fully agree with @jancborchardt 's suggestions above

@skjnldsv
Copy link
Member

skjnldsv commented Jan 8, 2020

  1. Turn the Open sidebar button into a Close sidebar button once the sidebar is opened

But the sidebar already have the close button, is hiding it good enough? :)

@wiswedel
Copy link
Author

wiswedel commented Jan 8, 2020

  1. Turn the Open sidebar button into a Close sidebar button once the sidebar is opened

But the sidebar already have the close button, is hiding it good enough? :)

no, see 3.

@juliusknorr
Copy link
Member

This is fixed these days in the viewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Experience, interaction, interface, … enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants