Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] Bump @nextcloud/dialogs to 4.2.0 #4794

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 14, 2023

No description provided.

@juliusknorr juliusknorr changed the base branch from main to stable27 September 14, 2023 10:12
@juliusknorr juliusknorr added dependencies Pull requests that update a dependency file 3. to review labels Sep 14, 2023
@juliusknorr
Copy link
Member Author

/compile

@juliusknorr juliusknorr force-pushed the chore/dependencies/bump-nextcloud-dialogs branch from 22318ff to 23774fe Compare September 14, 2023 10:34
@juliusknorr
Copy link
Member Author

/compile

@juliusknorr juliusknorr changed the title chore/dependencies/bump nextcloud dialogs [stable27] Bump @nextcloud/dialogs to 4.2.0 Sep 14, 2023
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🚀

Signed-off-by: Arthur Schiwon <[email protected]>
@cypress
Copy link

cypress bot commented Sep 14, 2023

Passing run #12089 ↗︎

0 149 2 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

[stable27] Bump @nextcloud/dialogs to 4.2.0
Project: Text Commit: 89b36de7c5
Status: Passed Duration: 23:51 💡
Started: Sep 14, 2023 4:35 PM Ended: Sep 14, 2023 4:58 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

Failures are only related to changes in selectors that are used for tests, can adapt shortly but would also be fine to merge and follow up

@juliusknorr
Copy link
Member Author

Fix pushed, passing fine locally now.

@juliusknorr juliusknorr force-pushed the chore/dependencies/bump-nextcloud-dialogs branch from 9c6be9d to 5d68c52 Compare September 14, 2023 16:22
@juliusknorr
Copy link
Member Author

/compile

@juliusknorr
Copy link
Member Author

Cannot figure out why local node build differs, let's use the one compiled by the action

Signed-off-by: nextcloud-command <[email protected]>
@juliusknorr juliusknorr merged commit e1cf241 into stable27 Sep 14, 2023
31 of 32 checks passed
@juliusknorr juliusknorr deleted the chore/dependencies/bump-nextcloud-dialogs branch September 14, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants