-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use deployment environment for js build #4773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
had a problem deploying
to
update-node-dist
September 6, 2023 11:50 — with
GitHub Actions
Failure
juliusknorr
had a problem deploying
to
update-node-dist
September 6, 2023 11:57 — with
GitHub Actions
Failure
juliusknorr
temporarily deployed
to
update-node-dist
September 6, 2023 11:58 — with
GitHub Actions
Inactive
office-team-bot
temporarily deployed
to
update-node-dist
September 6, 2023 12:01 — with
GitHub Actions
Inactive
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
ci/node-dist-workflow-test
branch
from
September 6, 2023 12:55
a96953c
to
7843329
Compare
juliusknorr
changed the title
ci/node dist workflow test
Use deployment environment for js build
Sep 6, 2023
max-nextcloud
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I lack the deeper understanding to predict if it will work - but definitely seems worth a try.
I can give a quick walk through next week :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix the lack of permission to build dist assets on main