Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deployment environment for js build #4773

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Sep 6, 2023

Should fix the lack of permission to build dist assets on main

@cypress
Copy link

cypress bot commented Sep 6, 2023

4 failed and 3 flaky tests on run #12046 ↗︎

4 136 18 0 Flakiness 3

Details:

ci/node dist workflow test
Project: Text Commit: a96953cafb
Status: Failed Duration: 05:30 💡
Started: Sep 6, 2023 12:15 PM Ended: Sep 6, 2023 12:21 PM
Failed  attachments.spec.js • 3 failed tests

View Output Video

Test Artifacts
Test all attachment insertion methods > test if attachment folder is moved with the markdown file Output Screenshots
Test all attachment insertion methods > test if attachment folder is copied when copying a markdown file Output Screenshots
Test all attachment insertion methods > [share] check everything behaves correctly on the share target user side Output Screenshots
Failed  share.spec.js • 1 failed test

View Output Video

Test Artifacts
Open test.md in viewer > Share a file with download disabled shows an error Output Screenshots
Flakiness  sync.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync > saves the actual file and document state Output Screenshots
Flakiness  nodes/FrontMatter.spec.js • 1 flaky test

View Output Video

Test Artifacts
Front matter support > Add front matter Output Screenshots
Flakiness  api/SyncServiceProvider.spec.js • 1 flaky test

View Output Video

Test Artifacts
Sync service provider > recovers from a dropped message Output Screenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr temporarily deployed to deploy September 6, 2023 10:57 — with GitHub Actions Inactive
@juliusknorr juliusknorr temporarily deployed to deploy September 6, 2023 11:06 — with GitHub Actions Inactive
@juliusknorr juliusknorr temporarily deployed to deploy September 6, 2023 11:08 — with GitHub Actions Inactive
@juliusknorr juliusknorr temporarily deployed to update-node-dist September 6, 2023 11:58 — with GitHub Actions Inactive
@office-team-bot office-team-bot temporarily deployed to update-node-dist September 6, 2023 12:01 — with GitHub Actions Inactive
@juliusknorr juliusknorr force-pushed the ci/node-dist-workflow-test branch from a96953c to 7843329 Compare September 6, 2023 12:55
@juliusknorr juliusknorr marked this pull request as ready for review September 6, 2023 12:57
@juliusknorr juliusknorr changed the title ci/node dist workflow test Use deployment environment for js build Sep 6, 2023
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I lack the deeper understanding to predict if it will work - but definitely seems worth a try.

@juliusknorr
Copy link
Member Author

I can give a quick walk through next week :)

@juliusknorr juliusknorr disabled auto-merge September 6, 2023 13:08
@juliusknorr juliusknorr merged commit baf744c into main Sep 6, 2023
37 of 38 checks passed
@juliusknorr juliusknorr deleted the ci/node-dist-workflow-test branch September 6, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants