-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use proper value for checking if editable #4721
Conversation
3 failed tests on run #12039 ↗︎
Details:
cypress/e2e/attachments.spec.js • 3 failed testsThis comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
/backport to stable27 |
789bdb8
to
0bb6bfe
Compare
Let's wait for #4663 so I can extend with a test for this one |
49aec00
to
00ba58a
Compare
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
00ba58a
to
ff3ea00
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/backport 468edd4 to stable27 |
Use the right property for checking if the editor is read only