From f79feca7dac4c1771a08a1fffc69712cea29fcfc Mon Sep 17 00:00:00 2001
From: Andy Scherzinger <info@andy-scherzinger.de>
Date: Wed, 4 Dec 2024 20:00:25 +0100
Subject: [PATCH] style(detekt): Comment on all EmptyFunctionBlock cases

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
---
 .../java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt   | 2 ++
 app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt    | 4 +++-
 detekt.yml                                                    | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt b/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt
index bf746199e2..d88f9989a1 100644
--- a/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt
+++ b/app/src/main/java/com/nextcloud/talk/jobs/LeaveConversationWorker.kt
@@ -62,9 +62,11 @@ class LeaveConversationWorker(context: Context, workerParams: WorkerParameters)
                 .observeOn(AndroidSchedulers.mainThread())
                 .subscribe(object : Observer<GenericOverall?> {
                     override fun onSubscribe(d: Disposable) {
+                        // unused atm
                     }
 
                     override fun onNext(p0: GenericOverall) {
+                        // unused atm
                     }
 
                     override fun onError(e: Throwable) {
diff --git a/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt b/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt
index f25c2967b6..6ca1937a66 100644
--- a/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt
+++ b/app/src/main/java/com/nextcloud/talk/utils/DisplayUtils.kt
@@ -197,7 +197,9 @@ object DisplayUtils {
                 .crossfade(true)
                 .transformations(CircleCropTransformation())
                 .target(object : Target {
-                    override fun onStart(placeholder: Drawable?) {}
+                    override fun onStart(placeholder: Drawable?) {
+                        // unused atm
+                    }
                     override fun onError(error: Drawable?) {
                         chip.chipIcon = error
                     }
diff --git a/detekt.yml b/detekt.yml
index e2620122bb..771890bf2c 100644
--- a/detekt.yml
+++ b/detekt.yml
@@ -1,7 +1,7 @@
 # SPDX-FileCopyrightText: 2017-2024 Nextcloud GmbH and Nextcloud contributors
 # SPDX-License-Identifier: GPL-3.0-or-later
 build:
-  maxIssues: 125
+  maxIssues: 122
   weights:
     # complexity: 2
     # LongParameterList: 1