fix: Use devcontainer with php v8.2 #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Dec 2, 2024
.devcontainer/devcontainer.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "image": "ghcr.io/juliushaertl/nextcloud-dev-php80:latest", | |||
| "image": "ghcr.io/juliushaertl/nextcloud-dev-php82:latest", | |||
There was a problem hiding this comment.
Should be this one these days ;)
Suggested change
| "image": "ghcr.io/juliushaertl/nextcloud-dev-php82:latest", | |
| "image": "ghcr.io/juliusknorr/nextcloud-dev-php82:latest", |
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
enjeck
force-pushed
the
devcontainer-update-php
branch
from
ae108f3 to
d4bb35a
Compare
blizzz
approved these changes
Dec 4, 2024
|
does it need a backport? |
I don't know. It depends if anyone using the devcontainer needs it, I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1392
Thanks to @MI-KY for doing the fix at #1393