Reactions notifications when fully subscribed in federated conversations

[nickvergessen]

In a federated conversations users do not receive notifications when they change the notification level to "always" and a reaction is done

Normal chats are handled in:

spreed/lib/Chat/Notifier.php

Lines 269 to 300 in 1ccbf67

	public function notifyReacted(Room $chat, IComment $comment, IComment $reaction): void {
	if ($comment->getActorType() !== Attendee::ACTOR_USERS) {
	return;
	}
	if ($comment->getActorType() === $reaction->getActorType() && $comment->getActorId() === $reaction->getActorId()) {
	return;
	}
	try {
	$participant = $this->participantService->getParticipant($chat, $comment->getActorId(), false);
	} catch (ParticipantNotFoundException $e) {
	return;
	}
	$notificationLevel = $participant->getAttendee()->getNotificationLevel();
	if ($notificationLevel === Participant::NOTIFY_DEFAULT) {
	if ($chat->getType() === Room::TYPE_ONE_TO_ONE) {
	$notificationLevel = Participant::NOTIFY_ALWAYS;
	} else {
	$notificationLevel = $this->getDefaultGroupNotification();
	}
	}
	if ($notificationLevel === Participant::NOTIFY_ALWAYS) {
	$notification = $this->createNotification($chat, $comment, 'reaction', [
	'reaction' => $reaction->getMessage(),
	], $reaction);
	$notification->setUser($comment->getActorId());
	$this->notificationManager->notify($notification);
	}
	}

And something alike should happen in

spreed/lib/Federation/Proxy/TalkV1/Notifier/MessageSentListener.php

Line 32 in 1ccbf67

class MessageSentListener implements IEventListener {

By "analysing" the system messages for reaction adding