A desperate second attempt to fix #263

[dertuxmalwieder]

Based upon the FreeBSD implementation and my own previous attempt... VERY lightly tested.

[kesselb]

Thanks for your pull request 👍

I'm not sure how to continue here. The linter and static analysis are failing. That's something we have to fix.

I took your changes a few weeks ago and tried to add some tests: https://github.com/nextcloud/serverinfo/compare/feat/sun-os

The current implementation is a bit unfinished.
Sorry, I can't spare the time to finish the unit tests, but I'm happy to answer your questions.

[dertuxmalwieder]

The current implementation is a bit unfinished.

Yes, I noticed that I made a few mistakes there, some of which caused by copy&paste after the initial version. Sorry for have wasted your time with that. That happens when you (= I) don't give myself enough time... I changed a few things, but yes, the lack of tests is a problem on my side. I wish I wouldn't even had to do that again though ... ;-)

[kesselb]

Thanks for your work on this pull request.

I’m closing it as the current implementation isn’t in a mergable state.

That said, I’m not against the feature itself! If someone wants to pick this up, I’d be happy to provide guidance to help move it forward. One important requirement for this feature is automated test coverage. This will ensure that the app remains maintainable for me without needing to set up a dedicated test installation on SunOS.

The restricted mode we introduced with Nextcloud 28 might help address your use case by preventing the execution of Linux commands that aren’t available on SunOS.

Thanks again for your contributions, and let me know if you have any questions or would like to revisit this in the future!