New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add units (seconds) to Max Execution Time value for PHP #342

Open

p-bo opened this issue Nov 28, 2021 · 1 comment

Labels

enhancement good first issue

p-bo commented Nov 28, 2021

Steps to reproduce

Go to Settings -> Administration -> System
Look at PHP section
Observe time value without units

Expected behaviour

Displayed:
Max Execution Time: xxxx sec (or another string according locale settings)
OR
Max Execution Time (seconds): xxxx (add units directly to value name string and let translators to deal with correct string for time units)

Actual behaviour

Displayed:
Max Execution Time: xxxx

Server configuration

Nextcloud version: 22.2.3

Where did you install. Nextcloud from: Nextcloud VM

Member

joshtrichards commented May 28, 2023

I had the same idea when I did #452 the other day (and nearly left it in).

It might be okay to just use s since it's an SI base value: https://en.m.wikipedia.org/wiki/International_System_of_Units

Feel free to send in a PR. :-)

joshtrichards added enhancement good first issue labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment