Forbid tagging readonly files #44297
Conversation
|
/backport! to stable28 |
|
/backport! to stable27 |
|
(I’m backporting first, I will fix conflicts after because the conflict is only for master branch) |
|
/backport! to stable26 |
|
/backport! to stable25 |
|
/backport! to stable24 |
|
/backport! to stable23 |
|
The backport to # Switch to the target branch and update it
git checkout stable23
git pull origin stable23
# Create the new backport branch
git checkout -b backport/44297/stable23
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 31cd2160 06b5919e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44297/stable23Error: Failed to push branch backport/44297/stable23: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
|
Rebased on master and fixed conflicts. Replaced the function content to more modern code to match the other function. |
come-nc
force-pushed
the
fix/forbid-tagging-readonly-files
branch
from
06b5919 to
c1b451e
Compare
come-nc
added
3. to review
come-nc
requested review from
nickvergessen,
a team,
ArtificialOwl,
artonge and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -75,7 +90,8 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| $entityExistsFunction | |||
| $entityExistsFunction, | |||
| fn ($name) => true, | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
come-nc
added
4. to release
…files Forbid tagging readonly files Signed-off-by: Louis Chemineau <[email protected]>
Summary
Forbid tagging a readonly file.
For other types that may be supported by systemtags if provided by an application (I do not know of any application actually using that feature), update is always allowed for now.
This should be followed by a PR to give a way for applications to provide a writeaccess function as well, for completeness sake.
Checklist