fix(settings): Support order property on App Discover elements and hide future elements
#44282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
Pytal,
szaimen and
emoral435
and removed request for
a team
|
/compile |
Merged
susnux
force-pushed
the
fix/app-discover-pin-and-parse
branch
2 times, most recently
from
ce0c991 to
9c6071f
Compare
Pytal
approved these changes
Mar 18, 2024
apps/settings/src/components/AppStoreDiscover/AppStoreDiscoverSection.vue
Show resolved
Hide resolved
artonge
approved these changes
Mar 19, 2024
…hide future elements This adds support to pinning elements by setting the `order` property on the element (e.g. `order: 0` will always be the first element to show). Also filter list of elements to remove upcoming and outdated elements (as the json might be cached). Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/app-discover-pin-and-parse
branch
from
9c6071f to
d5b1de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support to pinning elements by setting the
orderproperty on the element (e.g.order: 0will always be the first element to show). Also filter list of elements to remove upcoming and outdated elements (as the json might be cached).Checklist