Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Logger): Warn on invalid loglevel configuration option #44262

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 17, 2024

Summary

When the configuration is not a valid integer do not silently fallback to warn, instead try to cast it (might be more what the admin wanted to configure, e.g. allows '0' when 0 was meant).
And if the value is invalid do handle it not silently but at least put a warning in the log (even we do not have access to the logger we can put it in the error log.

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 17, 2024
@susnux susnux requested review from nickvergessen, a team, ArtificialOwl, nfebe and sorbaugh and removed request for a team March 17, 2024 20:17
@Altahrim Altahrim added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 18, 2024
@nickvergessen nickvergessen merged commit 3af954f into master Mar 18, 2024
167 checks passed
@nickvergessen nickvergessen deleted the fix/log-on-invalid-loglevel branch March 18, 2024 09:59
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
@skjnldsv
Copy link
Member

Thank you for the additional fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: logging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants