perf: improve performance of resolving group shares #44004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
added
3. to review
icewind1991
requested review from
a team,
ArtificialOwl,
nfebe and
sorbaugh
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
share-resolve-group-perf
branch
from
d28c1f7 to
1ce427d
Compare
skjnldsv
approved these changes
Mar 7, 2024
blizzz
reviewed
Mar 7, 2024
Altahrim
reviewed
Mar 8, 2024
Altahrim
force-pushed
the
share-resolve-group-perf
branch
2 times, most recently
from
ef4f968 to
45f0de2
Compare
Altahrim
approved these changes
Mar 15, 2024
skjnldsv
approved these changes
Mar 15, 2024
skjnldsv
added
4. to release
Signed-off-by: Robin Appelman <[email protected]>
skjnldsv
force-pushed
the
share-resolve-group-perf
branch
from
45f0de2 to
0e74972
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that the resolving of shares is creating a fairly significant load on the DB. Instead of sending a massive
INstatement, filtering just by the recipient is enough and should be a lot better on the DB.