Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(metadata): migrate metadata to lazy appconfig #43574

Merged
merged 1 commit into from
Apr 17, 2024
Merged

enh(metadata): migrate metadata to lazy appconfig #43574

merged 1 commit into from
Apr 17, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Feb 14, 2024 •
edited
Loading

  • store the 'known metadata' object, used to store type for each eventual keys, as a lazy appconfig value,
  • remove part of code that was only need for 28 migration
  • some changes in IMetadataQuery::__construct() to pass IFilesMetadataManager instead of IFilesMetadata to not load lazy appconfig values out of webdav search.
  • keeping __construct() compatible while generating a debug log when used with deprecated argument

@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Feb 14, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/lazyappconfig-migrate-metadata branch from 82611f9 to 4e1814a Compare February 14, 2024 14:30
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 23, 2024
@ArtificialOwl ArtificialOwl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 5, 2024
@susnux susnux requested review from a team, icewind1991, Altahrim and nfebe and removed request for a team March 11, 2024 12:32
come-nc
come-nc approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When are metadata loaded, only for specific queries?

This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl ArtificialOwl merged commit b4004a2 into master Apr 17, 2024
159 checks passed
@ArtificialOwl ArtificialOwl deleted the enh/noid/lazyappconfig-migrate-metadata branch April 17, 2024 17:20
@backportbot backportbot bot mentioned this pull request Apr 17, 2024
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@nfebe nfebe nfebe approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews performance 🚀
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@ArtificialOwl @nfebe @come-nc @blizzz @skjnldsv