fix(ui): Do not close all menus on right click #41812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
susnux,
juliusknorr,
NastuzziSamy and
Pytal
|
/compile amend / |
juliusknorr
approved these changes
Nov 28, 2023
Signed-off-by: Christoph Wurst <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
nextcloud-command
force-pushed
the
fix/ui/right-click-close-menu
branch
from
7b66219 to
84fd8b1
Compare
Pytal
approved these changes
Nov 28, 2023
|
/backport to stable26 |
ChristophWurst
added
4. to release
|
/backport to stable26 |
|
Any reason to target 27.1.6 instead 27.1.5? |
|
it was the next open milestone |
|
/backport to stable26 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Menus should close on unhandled click events in good old jquery land. This handling is a bit too much when paired with the files_rightclick feature. The files_rightclick acts on the click event. On touchpads, using two finger so click right also emits a mouseleave event, too, which wrongly closes all menus, and destroys the hidden element that files_rightlick tries to find when entries in the fake menu are clicked.
28 is not affected.
How to test
master: nothing happens
here: details sidebar shows
Checklist