-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve personal settings layout #41718
base: master
Are you sure you want to change the base?
Conversation
/compile amend / |
beb5725
to
0c2e7fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it and looks good from the screenrecording 👍
But didnt test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit extreme towards the other side, no? The information density is very low and the input fields / selects are uncharacteristically wide.
It would make sense to have a 2-column interface, with avatar, profile and groups in the left column (like now) and all the input field things in the right column. That would be more condensed while at the same time not strangely wide.
(Another issue with the layout or rather the UX is this whole "Profile visibility" section on the bottom which basically duplicates all the fields above. It would be great if we can combine that as well – but should be a separate concern of course.)
@jancborchardt how would the left column behave on scroll? If the concern is the width of the input, we can narrow the columns. Most other settings pages are one column too. |
Agreed that the width is a lot. I found a possibly useful (but very old) wireframe from when we were thinking about profile and its settings: Some ideas to reduce the width based on that screenshot:
|
I like the idea of having everything in one line, but I think that since this already improves things a lot, we should merge and then iterate over the actual design. |
@marcoambrosini I disagree on this – as said this goes too far in the other extreme direction. 2 columns would be the proper fix.
It can just scroll up and out of view, no need for stickyness there for now. @nimishavijay nice on the mockup indeed! Great also since this is the start of a new cycle, this could go in as an immediate follow-up for this. |
@jancborchardt do you mean like this? I think it's worse than 1 column, especially given that when we scrolled down it's still 1 column, just awkwardly placed on the screen. Screencast.from.2023-12-19.10-59-57.webm |
--> invert and align to the left |
@marcoambrosini another point: "Language" and "Locale" can move to the other column as they are personal (more like group memberships and quota usage) and don’t really fit with the others which are profile fields. |
Signed-off-by: Marco <[email protected]>
ff0eafb
to
f80b06a
Compare
/compile amend/ |
Signed-off-by: nextcloud-command <[email protected]>
589b8c1
to
4239bd5
Compare
In this two column design suggested:
REF: Screencast.from.2023-12-19.10-59-57.webmMy thoughts |
@fenn-cs it needs to scroll because with everything we added it's unlikely to fit in the height of the screen. The profile picture is on the right because otherwise when that column is scrolled away, the other column would be in an odd position: not at the center of the screen and not left aligned either. |
Summary
One column layout regardless of the width, like in other settings sections. Currently, it's centered, but it can also be moved to the left like in other sections. I just thought it looked better centered.
I think that this is a massive improvement in clarity and usability of this page, and a very low-hanging fruit too.
There's still a lot that can be done, but I think this is a step in the right direction.
Before
Screencast.from.2023-11-24.10-45-10.webm
After
Screencast.from.2023-11-24.11-58-26.webm
Checklist