Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve personal settings layout #41718

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Nov 24, 2023

  • Resolves: #

Summary

One column layout regardless of the width, like in other settings sections. Currently, it's centered, but it can also be moved to the left like in other sections. I just thought it looked better centered.
I think that this is a massive improvement in clarity and usability of this page, and a very low-hanging fruit too.
There's still a lot that can be done, but I think this is a step in the right direction.

Before

Screencast.from.2023-11-24.10-45-10.webm

After

Screencast.from.2023-11-24.11-58-26.webm

Checklist

@marcoambrosini
Copy link
Member Author

/compile amend /

@nextcloud-command nextcloud-command force-pushed the enh/noid/fix-personal-settings-layout branch from beb5725 to 0c2e7fc Compare November 24, 2023 03:26
@marcoambrosini marcoambrosini changed the title Improve personal settings layout [PoC] Improve personal settings layout Nov 28, 2023
szaimen
szaimen previously approved these changes Nov 28, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it and looks good from the screenrecording 👍
But didnt test

@szaimen szaimen added this to the Nextcloud 29 milestone Nov 28, 2023
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a bit extreme towards the other side, no? The information density is very low and the input fields / selects are uncharacteristically wide.

It would make sense to have a 2-column interface, with avatar, profile and groups in the left column (like now) and all the input field things in the right column. That would be more condensed while at the same time not strangely wide.

(Another issue with the layout or rather the UX is this whole "Profile visibility" section on the bottom which basically duplicates all the fields above. It would be great if we can combine that as well – but should be a separate concern of course.)

@marcoambrosini
Copy link
Member Author

marcoambrosini commented Dec 11, 2023

@jancborchardt how would the left column behave on scroll?

If the concern is the width of the input, we can narrow the columns. Most other settings pages are one column too.
As per the density, I think that the problem in the screenshot above is the avatar size: reducing it will also improve things a lot.

@nimishavijay
Copy link
Member

Agreed that the width is a lot. I found a possibly useful (but very old) wireframe from when we were thinking about profile and its settings:

image

Some ideas to reduce the width based on that screenshot:

  • Moving the scope from being an button next to the label to the end of the input field reduces the width of the input fields.
  • We could also make that icon-only button to an icon+text button, which also makes the meaning clearer
  • If we find a way to also move the profile visibility setting for the relevant fields to the end, the input field would be even smaller

@marcoambrosini
Copy link
Member Author

marcoambrosini commented Dec 18, 2023

I like the idea of having everything in one line, but I think that since this already improves things a lot, we should merge and then iterate over the actual design.
We can arbitrarily reduce the width as we see fit without having to justify the empty space, as long as the layout improves the user experience.

Ref: google settings
Group 1

@jancborchardt
Copy link
Member

I think that since this already improves things a lot, we should merge and then iterate over the actual design.

@marcoambrosini I disagree on this – as said this goes too far in the other extreme direction. 2 columns would be the proper fix.

how would the left column behave on scroll?

It can just scroll up and out of view, no need for stickyness there for now.

@nimishavijay nice on the mockup indeed! Great also since this is the start of a new cycle, this could go in as an immediate follow-up for this.

@marcoambrosini
Copy link
Member Author

marcoambrosini commented Dec 19, 2023

@jancborchardt do you mean like this? I think it's worse than 1 column, especially given that when we scrolled down it's still 1 column, just awkwardly placed on the screen.

Screencast.from.2023-12-19.10-59-57.webm

@marcoambrosini
Copy link
Member Author

--> invert and align to the left

@jancborchardt
Copy link
Member

@marcoambrosini another point: "Language" and "Locale" can move to the other column as they are personal (more like group memberships and quota usage) and don’t really fit with the others which are profile fields.

@marcoambrosini marcoambrosini force-pushed the enh/noid/fix-personal-settings-layout branch from ff0eafb to f80b06a Compare March 11, 2024 16:16
@marcoambrosini marcoambrosini added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 11, 2024
@marcoambrosini
Copy link
Member Author

/compile amend/

@nextcloud-command nextcloud-command force-pushed the enh/noid/fix-personal-settings-layout branch from 589b8c1 to 4239bd5 Compare March 11, 2024 16:57
@nfebe
Copy link
Contributor

nfebe commented Mar 11, 2024

In this two column design suggested:

  • It would make sense if the column that contains the profile picture is left aligned like in the original design while the rest of the columns is used to hold the other inputs. (20:80 percent ratio)
  • The left column should not scroll? (on large screens)

REF:

Screencast.from.2023-12-19.10-59-57.webm

My thoughts

@marcoambrosini
Copy link
Member Author

@fenn-cs it needs to scroll because with everything we added it's unlikely to fit in the height of the screen. The profile picture is on the right because otherwise when that column is scrolled away, the other column would be in an odd position: not at the center of the screen and not left aligned either.

@Altahrim Altahrim mentioned this pull request Mar 12, 2024
@skjnldsv skjnldsv changed the title [PoC] Improve personal settings layout Improve personal settings layout Mar 14, 2024
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
@szaimen
Copy link
Contributor

szaimen commented Mar 18, 2024

Great, looks much better layout-wise :)
Though I wonder is it expected that each section has a different width and aligning now?
See
localhost_8443_index php_settings_user (3)

This was referenced Mar 18, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
This was referenced Apr 4, 2024
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@marcoambrosini marcoambrosini added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 16, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🏗️ At engineering
Development

Successfully merging this pull request may close these issues.

7 participants