cleaner code with null safe #41478
Draft
cleaner code with null safe #41478
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
requested review from
a team,
icewind1991,
Altahrim and
sorbaugh
and removed request for
a team
Altahrim
approved these changes
Nov 15, 2023
Merged
|
same issue about null safe: vimeo/psalm#10316 The code is good, the error is a false positive. |
icewind1991
force-pushed
the
fix/noid/null-safe-metadata
branch
from
a4a92a7 to
1a5be94
Compare
icewind1991
approved these changes
Feb 9, 2024
|
if the false positive doesn't go away with the rebase you can suppress it with a comment |
ArtificialOwl
force-pushed
the
fix/noid/null-safe-metadata
branch
2 times, most recently
from
a770e58 to
a24bc14
Compare
Signed-off-by: Maxence Lange <[email protected]>
ArtificialOwl
force-pushed
the
fix/noid/null-safe-metadata
branch
from
a24bc14 to
681498a
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
|
Status @ArtificialOwl :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.